Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taps): Log JSONPatch match count at the INFO level #1999

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 5, 2023

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1999 (2986c00) into main (cb56f86) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage   87.39%   87.40%           
=======================================
  Files          59       59           
  Lines        5126     5130    +4     
  Branches      830      830           
=======================================
+ Hits         4480     4484    +4     
  Misses        451      451           
  Partials      195      195           
Files Coverage Δ
singer_sdk/helpers/jsonpath.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 5, 2023 23:17
@edgarrmondragon edgarrmondragon merged commit c203b61 into main Oct 6, 2023
28 checks passed
@edgarrmondragon edgarrmondragon deleted the 1609-feat-log-warning-message-when-jsonpath-expression-doesnt-match-anything branch October 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Log warning message when JSONPath expression doesn't match anything
1 participant