Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taps): Ensure default property is passed to SCHEMA messages #2015

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix(taps): Ensure default property is passed to SCHEMA messages #2015

merged 4 commits into from
Oct 11, 2023

Conversation

prakharcode
Copy link
Contributor

@prakharcode prakharcode commented Oct 11, 2023 •
edited by github-actions bot
Loading

Adding default property so that it can be passed over via schema message. This can be used by the target validators to populate records.

📚 Documentation preview 📚: https://meltano-sdk--2015.org.readthedocs.build/en/2015/

@prakharcode
Update schema.py
7ec3d6d 
Adding default property so that it can be passed over via schema message.
@prakharcode
Copy link
Contributor Author

#1998 (comment)
a bit of explanation here :)

@edgarrmondragon edgarrmondragon changed the title fix: adding default property to schema message. fix: Ensure default property is present in SCHEMA messages Oct 11, 2023
@edgarrmondragon edgarrmondragon changed the title fix: Ensure default property is present in SCHEMA messages fix(taps): Ensure default property is present in SCHEMA messages Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #2015 (7ec3d6d) into main (8ecbfb6) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 7ec3d6d differs from pull request most recent head 800af31. Consider uploading reports for the commit 800af31 to get more accurate results

@@           Coverage Diff           @@
##             main    #2015   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          58       58           
  Lines        4884     4884           
  Branches      777      777           
=======================================
  Hits         4241     4241           
  Misses        456      456           
  Partials      187      187
Files Coverage Δ
singer_sdk/_singerlib/schema.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title fix(taps): Ensure default property is present in SCHEMA messages fix(taps): Ensure default property is passed to SCHEMA messages Oct 11, 2023
edgarrmondragon
edgarrmondragon approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prakharcode!

(Coverage is acting up 🙄)

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Oct 11, 2023
Merged via the queue into meltano:main with commit a6d2819 Oct 11, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

@kgpayne kgpayne Awaiting requested review from kgpayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prakharcode @edgarrmondragon