Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement msgspec encoding #2539

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 17, 2024

Copy link

codspeed-hq bot commented Jul 17, 2024

CodSpeed Performance Report

Merging #2539 will improve performances by ×13

Comparing edgarrmondragon/refactor/msgspec-impl (913bc83) with main (32c059b)

Summary

⚡ 2 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark main edgarrmondragon/refactor/msgspec-impl Change
test_bench_deserialize_json 24.2 ms 11.1 ms ×2.2
test_bench_format_message 53.5 ms 4.1 ms ×13

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (32c059b) to head (913bc83).

Files Patch % Lines
singer_sdk/_singerlib/encoding/_msgspec.py 68.75% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
- Coverage   89.41%   89.14%   -0.28%     
==========================================
  Files          58       59       +1     
  Lines        4781     4845      +64     
  Branches      933      937       +4     
==========================================
+ Hits         4275     4319      +44     
- Misses        353      373      +20     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/msgspec-impl branch 6 times, most recently from c55112a to 750b114 Compare July 17, 2024 01:41
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/msgspec-impl branch from 750b114 to 913bc83 Compare July 17, 2024 01:59
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Aug 14, 2024
@edgarrmondragon edgarrmondragon removed this from the v0.41.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant