Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement abstract serialize_message for Singer writers #2540

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 17, 2024

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/serialize-message branch 4 times, most recently from 585e360 to d8b9716 Compare July 17, 2024 00:58
Copy link

codspeed-hq bot commented Jul 17, 2024

CodSpeed Performance Report

Merging #2540 will not alter performance

Comparing edgarrmondragon/refactor/serialize-message (6f3fd10) with main (4a066fe)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/serialize-message branch from d8b9716 to 6f3fd10 Compare July 17, 2024 01:02
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (4a066fe) to head (6f3fd10).
Report is 142 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2540   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          58       58           
  Lines        4779     4781    +2     
  Branches      933      933           
=======================================
+ Hits         4273     4275    +2     
  Misses        353      353           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 17, 2024 01:07
@edgarrmondragon edgarrmondragon merged commit 32c059b into main Jul 17, 2024
32 of 33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/serialize-message branch July 17, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant