Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Developers can now more easily override the mapping from SQL column type to JSON schema #2618

Conversation

Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #2618 will not alter performance

Comparing edgarrmondragon/feat/sqltype-to-json-schema-singledispatch (c57e23e) with main (efdc735)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sqltype-to-json-schema-singledispatch branch 3 times, most recently from d31b97c to a2f842a Compare August 21, 2024 21:07
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (efdc735) to head (c57e23e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
+ Coverage   89.61%   89.82%   +0.21%     
==========================================
  Files          58       58              
  Lines        4861     4884      +23     
  Branches      955      959       +4     
==========================================
+ Hits         4356     4387      +31     
+ Misses        352      346       -6     
+ Partials      153      151       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sqltype-to-json-schema-singledispatch branch 6 times, most recently from 39fe949 to f91aff4 Compare August 21, 2024 22:32
@edgarrmondragon edgarrmondragon added Needs Documentation kind/Feature New feature or request SQL Support for SQL taps and targets labels Aug 21, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 21, 2024 22:51
@edgarrmondragon edgarrmondragon marked this pull request as draft August 21, 2024 22:51
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Aug 21, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sqltype-to-json-schema-singledispatch branch from f91aff4 to af47b26 Compare August 22, 2024 00:03
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 22, 2024 01:05
@edgarrmondragon edgarrmondragon requested review from a team as code owners August 22, 2024 01:05
@edgarrmondragon edgarrmondragon changed the title feat: (WIP) Let developers more easily override SQL column type to JSON schema mapping feat: Developers can now more easily override the mapping from SQL column type to JSON schema Aug 22, 2024
@edgarrmondragon edgarrmondragon added the Release Highlight Call this out in the release notes label Aug 22, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sqltype-to-json-schema-singledispatch branch from 601f4c8 to ca2eab0 Compare August 24, 2024 19:22
@edgarrmondragon edgarrmondragon merged commit 7ea1422 into main Sep 6, 2024
36 of 37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/sqltype-to-json-schema-singledispatch branch September 6, 2024 16:53
@kgpayne
Copy link
Contributor

kgpayne commented Oct 24, 2024

Hey @edgarrmondragon 👋 This is great! Are there plans to replace singer_sdk.typing.to_sql_type() with a JSONSchemaToSQL class too? I am writing a target for Databricks and typing has been a real headache 🤕

@edgarrmondragon
Copy link
Collaborator Author

Hey @kgpayne, it's nice to see you around these parts!

Hey @edgarrmondragon 👋 This is great! Are there plans to replace singer_sdk.typing.to_sql_type() with a JSONSchemaToSQL class too? I am writing a target for Databricks and typing has been a real headache 🤕

That's the plan. I'll give it a try and see what I come up with tomorrow.

@edgarrmondragon
Copy link
Collaborator Author

edgarrmondragon commented Oct 25, 2024

#2732

@edgarrmondragon
Copy link
Collaborator Author

I've made a reference implementation in MeltanoLabs/target-postgres#469 if anyone's interested in looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request Needs Documentation Release Highlight Call this out in the release notes SQL Support for SQL taps and targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants