Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply repo-review to this project #2645

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 6, 2024

Applied pipx run 'sp-repo-review[cli]' . to this project.


📚 Documentation preview 📚: https://meltano-sdk--2645.org.readthedocs.build/en/2645/

Applied `pipx run 'sp-repo-review[cli]' .` to this proejct.
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #2645 will not alter performance

Comparing edgarrmondragon/chore/repo-review (ca3f0eb) with main (5d53b18)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (5d53b18) to head (ca3f0eb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
singer_sdk/authenticators.py 16.66% 5 Missing ⚠️
singer_sdk/streams/core.py 0.00% 1 Missing and 1 partial ⚠️
singer_sdk/tap_base.py 0.00% 2 Missing ⚠️
singer_sdk/connectors/sql.py 50.00% 0 Missing and 1 partial ⚠️
singer_sdk/helpers/_batch.py 0.00% 1 Missing ⚠️
singer_sdk/helpers/_state.py 0.00% 1 Missing ⚠️
singer_sdk/plugin_base.py 0.00% 1 Missing ⚠️
singer_sdk/streams/graphql.py 0.00% 1 Missing ⚠️
singer_sdk/testing/tap_tests.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          58       58           
  Lines        4854     4854           
  Branches      950      950           
=======================================
  Hits         4355     4355           
  Misses        348      348           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 6, 2024 15:57
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner September 6, 2024 15:57
@edgarrmondragon edgarrmondragon merged commit 63cc0a3 into main Sep 6, 2024
37 of 38 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/repo-review branch September 6, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant