Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support stream aliasing of BATCH messages via stream maps #2667

Merged

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented Sep 13, 2024

Adds support for BATCH messages with __alias__ using stream maps - a small step towards #1117.


📚 Documentation preview 📚: https://meltano-sdk--2667.org.readthedocs.build/en/2667/

@ReubenFrankel
Copy link
Contributor Author

ReubenFrankel commented Sep 13, 2024

Wasn't sure how/where to test this from the target side. Open to suggestions!

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #2667 will not alter performance

Comparing ReubenFrankel:feature/batch-stream-maps-alias (82290ba) with main (170f5bc)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (170f5bc) to head (82290ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2667      +/-   ##
==========================================
+ Coverage   89.86%   89.87%   +0.01%     
==========================================
  Files          58       58              
  Lines        4885     4891       +6     
  Branches      960      963       +3     
==========================================
+ Hits         4390     4396       +6     
  Misses        344      344              
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added the BATCH Support for BATCH messages label Sep 13, 2024
@edgarrmondragon edgarrmondragon added this to the v0.41.0 milestone Sep 13, 2024
@edgarrmondragon
Copy link
Collaborator

Wasn't sure how/where to test this from the target side. Open to suggestions!

I don't think there's anything we can base it off at the moment, but I'm happy to merge as is.

Thanks @ReubenFrankel!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Sep 13, 2024
Merged via the queue into meltano:main with commit d4a27a3 Sep 13, 2024
32 checks passed
@ReubenFrankel ReubenFrankel deleted the feature/batch-stream-maps-alias branch September 13, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BATCH Support for BATCH messages Community-Contributed PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants