Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Stopped testing with SQLAlchemy 1.4 #2716

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ env:

jobs:
tests:
name: "Test on ${{ matrix.python-version }} (${{ matrix.session }}) / ${{ matrix.os }} / SQLAlchemy: ${{ matrix.sqlalchemy }}"
name: "Test on ${{ matrix.python-version }} (${{ matrix.session }}) / ${{ matrix.os }}"
runs-on: ${{ matrix.os }}
continue-on-error: true
env:
Expand All @@ -55,12 +55,10 @@ jobs:
- "3.11"
- "3.12"
- "3.13"
sqlalchemy: ["2"]
include:
- { session: tests, python-version: "3.13", os: "ubuntu-latest", sqlalchemy: "1" }
- { session: doctest, python-version: "3.13", os: "ubuntu-latest", sqlalchemy: "2" }
- { session: mypy, python-version: "3.12", os: "ubuntu-latest", sqlalchemy: "2" }
- { session: deps, python-version: "3.12", os: "ubuntu-latest", sqlalchemy: "2" }
- { session: doctest, python-version: "3.13", os: "ubuntu-latest" }
- { session: mypy, python-version: "3.12", os: "ubuntu-latest" }
- { session: deps, python-version: "3.12", os: "ubuntu-latest" }

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -94,7 +92,6 @@ jobs:

- name: Run Nox
env:
SQLALCHEMY_VERSION: ${{ matrix.sqlalchemy }}
PIP_PRE: "1"
UV_PRERELEASE: allow
run: |
Expand Down
7 changes: 0 additions & 7 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ def tests(session: nox.Session) -> None:
session.install(f".[{','.join(extras)}]")
session.install(*test_dependencies)

sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")
if sqlalchemy_version:
session.install(f"sqlalchemy=={sqlalchemy_version}.*")

env = {"COVERAGE_CORE": "sysmon"} if session.python == "3.12" else {}

try:
Expand All @@ -103,9 +99,6 @@ def benches(session: nox.Session) -> None:
"""Run benchmarks."""
session.install(".[jwt,s3]")
session.install(*test_dependencies)
sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")
if sqlalchemy_version:
session.install(f"sqlalchemy=={sqlalchemy_version}")
session.run(
"pytest",
"--benchmark-only",
Expand Down
6 changes: 0 additions & 6 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import typing as t

import pytest
import sqlalchemy as sa

from singer_sdk import SQLConnector
from singer_sdk import typing as th
Expand Down Expand Up @@ -44,11 +43,6 @@ def pytest_runtest_setup(item):
pytest.skip(f"cannot run on platform {system}")


def pytest_report_header() -> list[str]:
"""Return a list of strings to be displayed in the header of the report."""
return [f"sqlalchemy: {sa.__version__}"]


@pytest.fixture(autouse=True)
def _reset_envvars(monkeypatch: pytest.MonkeyPatch):
"""Remove envvars that might interfere with tests."""
Expand Down
Loading