Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Object and array JSON types are now handled before primitive types when converting them to SQL types #2727

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 18, 2024

  • Add failing test
  • Prioritize object and array

📚 Documentation preview 📚: https://meltano-sdk--2727.org.readthedocs.build/en/2727/

@edgarrmondragon edgarrmondragon changed the title Prioritize object and array WIP(2726): Prioritize object and array Oct 18, 2024
@edgarrmondragon edgarrmondragon self-assigned this Oct 18, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 18, 2024
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #2727 will not alter performance

Comparing 2726-bug-json-schema-union-types-that-contain-boolean-result-in-casting-json-objects-and-arrays-as-boolean-values (4ffea35) with main (3bb3e5f)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (3bb3e5f) to head (4ffea35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2727   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files          62       62           
  Lines        5021     5021           
  Branches      641      641           
=======================================
  Hits         4555     4555           
  Misses        325      325           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…n-boolean-result-in-casting-json-objects-and-arrays-as-boolean-values
@edgarrmondragon edgarrmondragon changed the title WIP(2726): Prioritize object and array fix: Object and array JSON types are handled before primitive types when converting them to SQL types Oct 23, 2024
@edgarrmondragon edgarrmondragon changed the title fix: Object and array JSON types are handled before primitive types when converting them to SQL types fix: Object and array JSON types are now handled before primitive types when converting them to SQL types Oct 23, 2024
…n-boolean-result-in-casting-json-objects-and-arrays-as-boolean-values
@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 23, 2024 14:16
@edgarrmondragon edgarrmondragon added the SQL Support for SQL taps and targets label Oct 23, 2024
@edgarrmondragon edgarrmondragon merged commit fb9ac30 into main Oct 23, 2024
39 checks passed
@edgarrmondragon edgarrmondragon deleted the 2726-bug-json-schema-union-types-that-contain-boolean-result-in-casting-json-objects-and-arrays-as-boolean-values branch October 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL Support for SQL taps and targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: JSON schema union types that contain boolean result in casting JSON objects and arrays as boolean values
1 participant