Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Skip simpleeval 1.0.1 #2736

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 30, 2024

simpleeval 1.0.1 added pip as a runtime dependency. It doesn't seem to be tied to any functionality, but it can be problematic so I'm gonna skip it.

Related:


📚 Documentation preview 📚: https://meltano-sdk--2736.org.readthedocs.build/en/2736/

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner October 30, 2024 03:00
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #2736 will not alter performance

Comparing edgarrmondragon/packaging/no-simpleeval-1.0.1 (0562497) with main (863c173)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@863c173). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2736   +/-   ##
=======================================
  Coverage        ?   90.67%           
=======================================
  Files           ?       62           
  Lines           ?     5021           
  Branches        ?      641           
=======================================
  Hits            ?     4553           
  Misses          ?      326           
  Partials        ?      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon self-assigned this Oct 30, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 30, 2024
@edgarrmondragon edgarrmondragon merged commit ce6941f into main Oct 30, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/packaging/no-simpleeval-1.0.1 branch October 30, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant