Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

248-assumerole added ec2 instance role auth for assume role arn #249

Closed
wants to merge 1 commit into from

Conversation

bdebyl
Copy link
Contributor

@bdebyl bdebyl commented Jun 30, 2023

Fixes #248

Proposed Changes

  • Modified handling for S3 of Assume Role for case of running Drone pipeline with an EC2 Instance Role

Description

This will allow Drone Cache users running their Drone pipelines within AWS using EC2 Instance Roles to allow authentication for assuming another IAM Role.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date.

@bdebyl bdebyl requested a review from seandtaber as a code owner June 30, 2023 20:46
@bdebyl bdebyl closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Assume Role from Drone Pipeline Step
1 participant