Skip to content

Commit

Permalink
Node version updates (#18)
Browse files Browse the repository at this point in the history
This change updates the minimum support version of node to the current
LTS version (18/hydrogen).

This also removes the usage of the standard-things/esm package as the
entry point. Since this package is no longer maintained, newer language
features used in some internal dependencies were causing runtime errors.
Until we are ready to move this package fully over, we are using babel
to transpile down to a cjs friendly version.

Are there any breaking changes you are aware of in the PR?

[(Yes)]

If yes, what are they?

- Updated minimum supported node version
- Changed entry point for the package

## General Checklist

* [x] Change is tested locally
* [x] Demo is updated to exercise change (if applicable)
* [x] [WIP] flag is removed from the title
  • Loading branch information
mattquinlan440 committed Aug 18, 2023
1 parent f7d902b commit 12b5197
Show file tree
Hide file tree
Showing 12 changed files with 5,260 additions and 1,560 deletions.
12 changes: 12 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"presets": [
[
"@babel/preset-env",
{
"targets": {
"node": "current"
}
}
]
]
}
8 changes: 3 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jspm_packages/

# TypeScript v1 declaration files
typings/
types/

# TypeScript cache
*.tsbuildinfo
Expand Down Expand Up @@ -81,12 +82,9 @@ typings/
# parcel-bundler cache (https://parceljs.org/)
.cache

# Next.js build output
.next

# Nuxt.js build / generate output
.nuxt
# Build output
dist
cjs

# Gatsby files
.cache/
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/fermium
lts/hydrogen
2 changes: 1 addition & 1 deletion demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "src/index.js",
"types": "./types/index.d.ts",
"scripts": {
"start": "node ../src/cli.entry.js -i index.source.html -o index.html && ws --spa index.html"
"start": "node ../cjs/cli.entry.js -i index.source.html -o index.html && ws --spa index.html"
},
"devDependencies": {
"local-web-server": "5.2.1"
Expand Down
2 changes: 1 addition & 1 deletion jasmine.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"helper paths are relative to": "spec_dir",
"helpers": [
"../node_modules/esm/esm.js"
"../node_modules/@babel/register/lib/index.js"
],
"jsLoader": "require",
"spec_dir": "./src",
Expand Down
Loading

0 comments on commit 12b5197

Please sign in to comment.