Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version updates #18

Merged
merged 10 commits into from
Aug 18, 2023
Merged

Node version updates #18

merged 10 commits into from
Aug 18, 2023

Conversation

mattquinlan440
Copy link
Contributor

Thanks for opening a Pull Request

Changes

Please outline the reason for the changes you are making:

This change updates the minimum support version of node to the current LTS version (18/hydrogen).

This also removes the usage of the standard-things/esm package as the entry point. Since this package is no longer maintained, newer language features used in some internal dependencies were causing runtime errors. Until we are ready to move this package fully over, we are using babel to transpile down to a cjs friendly version.

Are there any breaking changes you are aware of in the PR?

[(Yes)]

If yes, what are they?

  • Updated minimum supported node version
  • Changed entry point for the package

General Checklist

  • Change is tested locally
  • Demo is updated to exercise change (if applicable)
  • [WIP] flag is removed from the title

@mattquinlan440 mattquinlan440 requested a review from a team as a code owner August 9, 2023 13:20
package.json Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
Copy link
Member

@jtheriault jtheriault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this LGTM!

@mattquinlan440 mattquinlan440 merged commit 12b5197 into main Aug 18, 2023
3 checks passed
@mattquinlan440 mattquinlan440 deleted the node-version-updates branch August 18, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants