From 00446a510957476c9b5b0aa3cdc367c5d061aae7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6rdes?= Date: Fri, 6 Sep 2024 12:47:35 +0200 Subject: [PATCH] Refactor HeaderField and HeaderName constructors for efficiency Remove unnecessary object creation in HeaderField copy constructor. Simplify HeaderName by removing redundant copy constructor. --- .../main/java/com/predic8/membrane/core/http/HeaderField.java | 3 ++- .../main/java/com/predic8/membrane/core/http/HeaderName.java | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/com/predic8/membrane/core/http/HeaderField.java b/core/src/main/java/com/predic8/membrane/core/http/HeaderField.java index 14e4c47e7..6b1d4aa82 100644 --- a/core/src/main/java/com/predic8/membrane/core/http/HeaderField.java +++ b/core/src/main/java/com/predic8/membrane/core/http/HeaderField.java @@ -45,9 +45,10 @@ public HeaderField(String headerName,String value) { } public HeaderField(HeaderField element) { - headerName = new HeaderName(element.headerName); + headerName = element.headerName; value = element.value; } + public String getValue() { return value; } diff --git a/core/src/main/java/com/predic8/membrane/core/http/HeaderName.java b/core/src/main/java/com/predic8/membrane/core/http/HeaderName.java index aa8e8ccc5..33f5eb286 100644 --- a/core/src/main/java/com/predic8/membrane/core/http/HeaderName.java +++ b/core/src/main/java/com/predic8/membrane/core/http/HeaderName.java @@ -29,10 +29,6 @@ public HeaderName(String name) { this.name = name; } - public HeaderName(HeaderName hn) { - this.name = hn.name; - } - @Override public boolean equals(Object obj) { return (this == obj) || (obj instanceof HeaderName hn) && (name.equalsIgnoreCase((hn.name)));