Removed barely utilized interceptor.id

membrane · Jul 21, 2023 · ae93e12 · ae93e12
1 parent d4aeb25
commit ae93e12
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 22 deletions.
diff --git a/core/src/main/java/com/predic8/membrane/core/interceptor/AbstractInterceptor.java b/core/src/main/java/com/predic8/membrane/core/interceptor/AbstractInterceptor.java
@@ -34,8 +34,6 @@ public class AbstractInterceptor implements Interceptor {
 
 	private EnumSet<Flow> flow = Flow.Set.REQUEST_RESPONSE;
 
-	protected String id;
-
 	protected Router router;
 
 	public AbstractInterceptor() {
@@ -62,15 +60,6 @@ public void setDisplayName(String name) {
 		this.name = name;
 	}
 
-	public String getId() {
-		return id;
-	}
-
-	@MCAttribute
-	public void setId(String id) {
-		this.id = id;
-	}
-
 	public void setFlow(EnumSet<Flow> flow) {
 		this.flow = flow;
 	}

diff --git a/core/src/main/java/com/predic8/membrane/core/interceptor/Interceptor.java b/core/src/main/java/com/predic8/membrane/core/interceptor/Interceptor.java
@@ -53,9 +53,6 @@ public static class Set {
 	String getDisplayName();
 	void setDisplayName(String name);
 
-	String getId();
-	void setId(String id);
-
 	Router getRouter();
 
 	void setFlow(EnumSet<Flow> flow);

diff --git a/...n/java/com/predic8/membrane/core/interceptor/authentication/session/LoginInterceptor.java b/...n/java/com/predic8/membrane/core/interceptor/authentication/session/LoginInterceptor.java
@@ -160,8 +160,7 @@ else if (s == null || !s.isAuthorized()) {
 	}
 
 	private void applyBackendAuthorization(Exchange exc, Session s) {
-        if (getId() != null)
-            exc.setProperty(getId() + "-session", s);
+        exc.setProperty("session", s);
         Header h = exc.getRequest().getHeader();
 		for (Map.Entry<String, String> e : s.getUserAttributes().entrySet())
 			if (e.getKey().startsWith("header")) {

diff --git a/core/src/test/java/com/predic8/membrane/core/rules/ProxyRuleTest.java b/core/src/test/java/com/predic8/membrane/core/rules/ProxyRuleTest.java
@@ -58,9 +58,7 @@ public void testRule() throws Exception {
 
 		List<Interceptor> inters = rule.getInterceptors();
 		assertFalse(inters.isEmpty());
-		assertTrue(inters.size()  == 2);
-		inters.get(0).getId().equals("roundRobinBalancer");
-		inters.get(1).getId().equals("accessControlInterceptor");
+		assertTrue(inters.size() == 2);
 
 		assertEquals(true, rule.isBlockResponse());
 		assertFalse(rule.isBlockRequest());
@@ -69,11 +67,9 @@ public void testRule() throws Exception {
 	private static List<Interceptor> getInterceptors() {
 		List<Interceptor> interceptors = new ArrayList<>();
 		Interceptor balancer = new LoadBalancingInterceptor();
-		balancer.setId("roundRobinBalancer");
 		interceptors.add(balancer);
 
 		Interceptor acl = new AccessControlInterceptor();
-		acl.setId("accessControlInterceptor");
 		interceptors.add(acl);
 		return interceptors;
 	}

diff --git a/core/src/test/resources/ref.proxies.xml b/core/src/test/resources/ref.proxies.xml
@@ -28,7 +28,6 @@
 
 	<spring:bean id="accessControlInterceptor"
 		class="com.predic8.membrane.core.interceptor.acl.AccessControlInterceptor">
-		<spring:property name="id" value="accessControlInterceptor" />
 		<spring:property name="displayName" value="Access Control List Interceptor" />
 		<spring:property name="file" value="acl/acl.xml" />
 	</spring:bean>