Fix bug in handling events in Depayloader #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mat-hek CI fails because of the too old version of |
mat-hek
requested changes
Aug 2, 2024
lib/membrane_rtp_vp8/depayloader.ex
Outdated
| @@ -37,8 +37,16 @@ defmodule Membrane.RTP.VP8.Depayloader do | |||
| end | |||
|
|
|||
| @impl true | |||
| def handle_event(:input, %Discontinuity{} = event, _ctx, state), | |||
| do: {[forward: event], %State{state | frame_acc: %Frame{}}} | |||
| def handle_event(pad, event, _ctx, state) do | |||
There was a problem hiding this comment.
IMO it would be clearer with a separate clause for upstream events
FelonEkonom
force-pushed
the
fix-handling-events-in-depayloader
branch
from
4e4ca80 to
e45e4b8
Compare
mat-hek
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depayloader ignores all events except Discontiunity