Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON-RPC v2 errors #103

Open
wants to merge 1 commit into
base: mempool
Choose a base branch
from
Open

Fix JSON-RPC v2 errors #103

wants to merge 1 commit into from

Conversation

junderw
Copy link
Sponsor Member

@junderw junderw commented Sep 14, 2024

Fixes #102

junderw
junderw commented Sep 14, 2024
View reviewed changes
src/electrum/server.rs
@@ -461,7 +483,7 @@ impl Connection {
params,
e.display_chain()
);
json!({"jsonrpc": "2.0", "id": id, "error": format!("{}", e)})
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the main problem area from the connected issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-RPC errors are sent as string instead of object, not following JSON-RPC spec
1 participant
@junderw