parse flags before reading configuration

mercari · Oct 4, 2023 · 3e9d7a4 · 3e9d7a4
1 parent 70701ce
commit 3e9d7a4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/main.go b/main.go
@@ -79,18 +79,19 @@ func main() {
 	// Tortoise specific flags
 	var configPath string
 	flag.StringVar(&configPath, "config", "", "The path to the config file.")
-	config, err := config.ParseConfig(configPath)
-	if err != nil {
-		setupLog.Error(err, "failed to load config")
-		os.Exit(1)
-	}
 
 	opts := zap.Options{
 		Development: true,
 	}
 	opts.BindFlags(flag.CommandLine)
 	flag.Parse()
 
+	config, err := config.ParseConfig(configPath)
+	if err != nil {
+		setupLog.Error(err, "failed to load config")
+		os.Exit(1)
+	}
+
 	ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
 
 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{

diff --git a/pkg/config/testdata/config.yaml b/pkg/config/testdata/config.yaml
@@ -1,5 +1,5 @@
 RangeOfMinMaxReplicasRecommendationHours: 2
-MinMaxReplicasRecommendationType:                    "daily"
+MinMaxReplicasRecommendationType:         "daily"
 TTLHoursOfMinMaxReplicasRecommendation:   720
 MaxReplicasFactor:                        2.0
 MinReplicasFactor:                        0.5