fix lint

mercari · Dec 13, 2024 · 7c0e997 · 7c0e997
1 parent 2e261c4
commit 7c0e997
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/internal/controller/tortoise_controller.go b/internal/controller/tortoise_controller.go
@@ -242,7 +242,7 @@ func (r *TortoiseReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_
 	}
 	scalingActive, err := r.HpaService.CheckHpaMetricStatus(ctx, hpa)
 	if err != nil {
-		if tortoise.Status.TortoisePhase == autoscalingv1beta3.TortoisePhaseWorking && hpaCreated == false {
+		if tortoise.Status.TortoisePhase == autoscalingv1beta3.TortoisePhaseWorking && !hpaCreated {
 			logger.Error(err, "HPA status abnormal", "tortoise", req.NamespacedName)
 			return ctrl.Result{}, err
 		}

diff --git a/pkg/tortoise/tortoise_test.go b/pkg/tortoise/tortoise_test.go
@@ -4706,7 +4706,10 @@ func TestService_UpdateTortoisePhaseIfHPAIsUnhealthy(t *testing.T) {
 				lastTimeUpdateTortoise: make(map[client.ObjectKey]time.Time),
 			}
 
-			s.UpdateTortoisePhaseIfHPAIsUnhealthy(context.Background(), tt.args.scalingActive, tt.args.t)
+			tt.args.t, err := s.UpdateTortoisePhaseIfHPAIsUnhealthy(context.Background(), tt.args.scalingActive, tt.args.t)
+			if err != nil {
+				t.Fatalf("failed to update tortoise phase: %v", err)
+			}
 			if d := cmp.Diff(tt.args.t, tt.wantTortoise); d != "" {
 				t.Errorf("UpdateTortoiseStatus() diff = %v", d)
 			}