Skip to content

Commit

Permalink
use isSuperset for comparison in isMonitorVPAReady instead of Equals
Browse files Browse the repository at this point in the history
isMonitorVPAReady now correctly checks that the VPA has recommendations for at least Tortoise defined containers, extra containers doesn't result in a false not ready.
  • Loading branch information
Dymanik authored Sep 23, 2024
1 parent b9f4a1c commit e885474
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/vpa/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func isMonitorVPAReady(vpa *v1.VerticalPodAutoscaler, tortoise *autoscalingv1bet
}
}

return containerInTortoise.Equal(containerInVPA)
return containerInVPA.IsSuperset(containerInTortoise)
}

func SetAllVerticalContainerResourcePhaseWorking(tortoise *autoscalingv1beta3.Tortoise, now time.Time) *autoscalingv1beta3.Tortoise {
Expand Down

0 comments on commit e885474

Please sign in to comment.