pre-allocate diag error accumulator slice

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
mergenci · Jan 30, 2024 · 25e29bd · 25e29bd
1 parent 13e848e
commit 25e29bd
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/controller/external_terraform_plugin_framework.go b/pkg/controller/external_terraform_plugin_framework.go
@@ -626,8 +626,9 @@ func getFatalDiagnostics(diags []*tfprotov5.Diagnostic) error {
 }
 
 func frameworkDiagnosticsToString(fwdiags fwdiag.Diagnostics) string {
-	var diagErrors []string
-	for _, tfdiag := range fwdiags.Errors() {
+	frameworkErrorDiags := fwdiags.Errors()
+	diagErrors := make([]string, 0, len(frameworkErrorDiags))
+	for _, tfdiag := range frameworkErrorDiags {
 		diagErrors = append(diagErrors, fmt.Sprintf("%s: %s", tfdiag.Summary(), tfdiag.Detail()))
 	}
 	return strings.Join(diagErrors, "\n")