Lazy load dictionary message bundles (sites not registered upon modul…

…e startup)
merkle-open · Nov 21, 2024 · 1439f82 · 1439f82
1 parent ac81332
commit 1439f82
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/magnolia-dictionary/src/main/java/com/namics/oss/magnolia/dictionary/DictionaryModule.java b/magnolia-dictionary/src/main/java/com/namics/oss/magnolia/dictionary/DictionaryModule.java
@@ -55,7 +55,6 @@ public void start(ModuleLifecycleContext moduleLifecycleContext) {
 			LOG.info("Start Dictionary module: Load labels to dictionary");
 			messagesInstaller.loadLabelsToDictionary();
 		}
-		dictionaryMessageBundlesLoader.reload();
 	}
 
 	@Override

diff --git a/...in/java/com/namics/oss/magnolia/dictionary/i18nsystem/DictionaryMessageBundlesLoader.java b/...in/java/com/namics/oss/magnolia/dictionary/i18nsystem/DictionaryMessageBundlesLoader.java
@@ -37,7 +37,7 @@
 public class DictionaryMessageBundlesLoader implements EventListener {
     private static final Logger LOG = LoggerFactory.getLogger(DictionaryMessageBundlesLoader.class);
     private final Provider<SystemContext> systemContextProvider;
-    private Map<Locale, Properties> messages = Collections.emptyMap();
+    private Map<Locale, Properties> messages;
 
     @Inject
     public DictionaryMessageBundlesLoader(final Provider<SystemContext> systemContextProvider) {
@@ -84,6 +84,9 @@ private Stream<Map.Entry<String, String>> streamMessages(final Locale locale, fi
     }
 
     public Map<Locale, Properties> getMessages() {
+        if(messages == null) {
+            reload();
+        }
         return messages;
     }
 

diff --git a/magnolia-dictionary/src/main/resources/META-INF/magnolia/magnolia-dictionary.xml b/magnolia-dictionary/src/main/resources/META-INF/magnolia/magnolia-dictionary.xml
@@ -43,6 +43,16 @@
             <name>i18n</name>
             <version>*/*</version>
         </dependency>
+        <dependency>
+            <name>site</name>
+            <version>*</version>
+            <optional>true</optional>
+        </dependency>
+        <dependency>
+            <name>multisite</name>
+            <version>*</version>
+            <optional>true</optional>
+        </dependency>
     </dependencies>
 
     <repositories>