Skip to content

Commit

Permalink
refactor(components): adjust fragment components to use consistent da…
Browse files Browse the repository at this point in the history
…ta attributes

- Remove redundant `:data-from` attribute
- Add missing `:data-origin` attribute to FragmentCritical, FragmentLoop, FragmentPar, FragmentRef, and FragmentTryCatchFinally components
- Reorder attributes for better readability
  • Loading branch information
MrCoder committed Nov 28, 2024
1 parent 37b0a17 commit 140975d
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<template>
<div
:data-origin="origin"
:data-from="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<template>
<div
:data-origin="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
class="fragment critical border-skin-fragment rounded relative"
:style="fragmentStyle"
>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<template>
<div
:data-origin="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
class="fragment loop border-skin-fragment rounded"
:style="fragmentStyle"
>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<template>
<div
:data-origin="origin"
:data-from="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<template>
<div class="fragment par border-skin-fragment rounded" :style="fragmentStyle">
<div
:data-origin="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
class="fragment par border-skin-fragment rounded"
:style="fragmentStyle"
>
<comment
v-if="commentObj.text"
:comment="comment"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<template>
<div
:data-origin="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
class="fragment bg-skin-frame border-skin-fragment relative rounded min-w-[140px] w-max py-4 px-2 flex justify-center items-center flex-col"
:style="fragmentStyle"
>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<template>
<div
class="fragment section border-skin-fragment rounded"
:style="fragmentStyle"
:data-origin="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
:data-left-participant="leftParticipant"
class="fragment section border-skin-fragment rounded"
:style="fragmentStyle"
>
<div class="segment">
<comment
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<template>
<div class="fragment tcf border-skin-fragment rounded" :style="fragmentStyle">
<div
:data-origin="origin"
:data-left-participant="leftParticipant"
:data-frame-padding-left="border.left"
:data-frame-padding-right="border.right"
class="fragment tcf border-skin-fragment rounded"
:style="fragmentStyle"
>
<div class="segment">
<comment
v-if="commentObj.text"
Expand Down

0 comments on commit 140975d

Please sign in to comment.