fix: ensure defaults don't override object-like properties in base file

mernxl · Jun 1, 2021 · c65b9dd · c65b9dd
1 parent dc2a04f
commit c65b9dd
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 8 deletions.
diff --git a/__mocks__/properties1/app.ini b/__mocks__/properties1/app.ini
@@ -1,2 +1,6 @@
 # Base config file
 CHANGED_VAR=${CHANGED_VAR}
+
+[field]
+# should pass with this comment
+checker=checker
diff --git a/__test__/__snapshots__/index.spec.ts.snap b/__test__/__snapshots__/index.spec.ts.snap
@@ -15,7 +15,14 @@ Object {
 }
 `;
 
-exports[`loadConfig load order should override defaults with env vars 1`] = `"Changed in process.env"`;
+exports[`loadConfig load order should override defaults with env vars 1`] = `
+Object {
+  "CHANGED_VAR": "Changed in process.env",
+  "field": Object {
+    "checker": "checker",
+  },
+}
+`;
 
 exports[`loadConfig load order should parse correctly 1`] = `"Changed in process.env"`;
 

diff --git a/__test__/index.spec.ts b/__test__/index.spec.ts
@@ -32,7 +32,7 @@ describe('loadConfig', () => {
   });
 
   describe('load order', () => {
-    beforeAll(() => {
+    beforeEach(() => {
       process.env.CHANGED_VAR = 'Changed in process.env';
     });
 
@@ -42,9 +42,15 @@ describe('loadConfig', () => {
 
     it('should override defaults with env vars', () => {
       expect(
-        loadConfig('__mocks__/properties1/app.ini', {
-          CHANGED_VAR: 'Initial, Default',
-        }).CHANGED_VAR,
+        pick(
+          ['CHANGED_VAR', 'field'],
+          loadConfig('__mocks__/properties1/app.ini', {
+            CHANGED_VAR: 'Initial, Default',
+            field: {
+              checker: 'initial',
+            },
+          }),
+        ),
       ).toMatchSnapshot();
     });
   });

diff --git a/src/index.ts b/src/index.ts
@@ -129,21 +129,25 @@ export function loadConfig<
 
     // load env file
     if (fs.existsSync(envDepPropsPath)) {
-      vars = mergeDeepRight(vars, parseProperties<InternalType>(envDepPropsPath, vars) as any);
+      vars = mergeDeepRight(
+        vars,
+        parseProperties<InternalType>(envDepPropsPath, mergeDeepRight(vars, process.env)) as any,
+      );
     }
   }
 
   // required file's local
-  const requiredLocal = loadLocalPoint<LocalsType>(filePath, vars);
+  const requiredLocal = loadLocalPoint<LocalsType>(filePath, mergeDeepRight(vars, process.env));
   if (requiredLocal) {
     vars = mergeDeepRight(requiredLocal as any, vars);
   }
 
   // we only get vars as seen in the fileName file
   vars = mergeDeepRight(
-    parseProperties<PropType>(path.resolve(filePath), mergeDeepRight(vars, process.env)) as any,
     vars,
+    parseProperties<PropType>(path.resolve(filePath), mergeDeepRight(vars, process.env)) as any,
   );
 
+  // process.env always have priority
   return mergeDeepRight(vars, process.env as any);
 }