Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfill buy-02 audit checklist #37

Open
14 of 19 tasks
adrian-lui opened this issue Dec 17, 2023 · 0 comments
Open
14 of 19 tasks

Fulfill buy-02 audit checklist #37

adrian-lui opened this issue Dec 17, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@adrian-lui
Copy link
Collaborator

adrian-lui commented Dec 17, 2023

We need to improve the existing buy-01 project to buy-02.

The plan is that backend will provide all the Orders and Products info in json format from the API, and frontend will handle the search, filter, and user profile functionality. Bonus features will not be done because we want to finish quick! :)

@maximihajlov will handle backend java spring app and database requirements

  1. Update database with new tables and fields
  2. Add Orders microservice

@adrian-lui will handle frontend app requirement

  1. Add new feature to make product order for users
  2. Add new feature to user/seller profile section
  3. Add Search/filter feature to product listing page

Other issues:

  1. Ensure best practices in collaborative development process with PRs and reviews.
  2. Use CI/CD pipeline to automatically build, test, and deploy PRs (with Jenkins or GH, TBC)
  3. Utilize SonarQube to ensure code quality and adherence to best practices.
  4. Proper documentation of the new features.
  5. Ensure unit testing in both frontend and backend

Acceptance criteria: Check all checkboxes above, and fulfill buy-02 audit checklist below.

Functional

  • Verify that the necessary tables, fields, relations are added.

    • Has the database design been correctly implemented?
    • Have the students added new relationships and have they used them correctly?
    • Did the students convince you with their additions to the database?
  • Review the project repository to check for PRs and code reviews.

    • Are developers following a collaborative development process with PRs and code reviews?
  • Check the implementation of Orders MicroService, User Profile, Search and Filtering, and Shopping Cart functionalities.

    • Are the implemented functionalities consistent with the project instructions?
    • Are the implemented functionalities clean and do they not pop up any errors or warnings in both back and front end?
  • Add products to the shopping cart and refresh the page.

    • Are the added products still in the shopping cart with the selected quantities?
  • Utilize SonarQube to assess code quality and check for improvements based on SonarQube feedback.

    • Are code quality issues identified by SonarQube being addressed and fixed?
  • Review the user interface to ensure it's user-friendly and responsive.

    • Does the application provide a seamless and responsive user experience?
  • Check if proper error handling and validation mechanisms are in place.

    • Are user interactions handled gracefully with appropriate error messages?
  • Verify the implementation of security measures as specified in the project instructions.

    • Are security measures consistently applied throughout the application?

Collaboration and Development Process

  • Check the repository's PR history and comments to ensure code reviews are conducted.

    • Are code reviews being performed for each PR?
  • Inspect the CI/CD pipeline configuration with Jenkins to ensure automated builds, tests, and deployments.

    • Is the CI/CD pipeline correctly set up and being utilized for PRs?
  • Examine the repository log and PR merges to ensure that branches are being merged as instructed.

    • Are branches merged correctly, and is the main codebase up-to-date?
  • Run a full test of the application to assess functionality and identify any issues.

    • Does the application pass a comprehensive test to ensure that all new features work as expected?
  • Inspect the codebase for unit tests related to different parts of the application.

    • Are there unit tests in place for critical parts of the application?
@adrian-lui adrian-lui added the documentation Improvements or additions to documentation label Dec 17, 2023
@adrian-lui adrian-lui added this to the buy-02 milestone Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants