[pull] master from cryptocorrosion:master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Without this change the pivot-around-b tweak would cause a performance regression on pre-AVX2 Intel archs. With this adjustment, the new diagonalization is faster across the board.
New benchmark tests performance when user requests data a little bit at a time so we never get a chance to use the wide impl.
Provide stream_eq to compare streams, irrespective of their current position.
For the machine-specific tests in ppv-lite86, use compile-time feature detection to #[ignore] unavailable tests. Must compile with RUSTFLAGS="-C target-cpu=native" to run all supported low-level tests (added to Travis config).
`simd` does not make a useful feature, because there is no way for a user to be dependent on it being enabled (I don't expose any SIMD-only interfaces). Rather, `no_simd` is a feature, because some users can't compile SIMD intrinsics for various reasons. Fixes #25. This has the additional benefit of eliminating a default-feature, a facility I have found to be a Cargo misfeature.
(And disable 64-bit blake tests until fixed)
Not sure how long build has been broken on 1.31.1, Travis was off.
For wasm32 compatibility. Implements #33.
The new versions of the RustCrypto crates all have MSRV 1.41.0.
Requires migrating threefish-cipher to block-cipher 0.7.
cipher 0.3
Use generic implementation on x86-without-simd
Some code relied on the layout of types with no `#[repr(...)]` attribute, which is unsound since the layout of these types is not guaranteed by rustc. This change adds the appropriate `repr` attributes and replaces unsafe code with safe code where possible.
Configure github workflow to run tests
Fix some unsoundness and remove some unsafe
Update dependencies
Use zerocopies derive feature rather than depending on zerocopy_derive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )