Sort by hostname instead of task ID #826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user click on "ID" column header in task list view, the real intent is likely to sort by hostname instead of sorting by task id. Marathon task id are ~random so sorting on them does not make sense. Sorting on hostname actually makes more sense for people. A better commit would sort on host+port but this one is likely good enough. Change-Id: Ia83cab32d4ac2353da07bc26ce8094c54d17c75e
|
@Poltergeist would you have time to give me feedback on this patch please? |
|
@Poltergeist would you be the right contact for this change? |
|
I am unfortunately not maintaining this repository anymore maybe @juliangieseke @DanielMSchmidt or @pierrebeitz are able to help here. |
DanielMSchmidt
requested review from
pierrebeitz
and removed request for
Poltergeist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user click on "ID" column header in task list view, the real intent
is likely to sort by hostname instead of sorting by task id.
Marathon task ids are ~random so sorting on them does not really make sense.
Sorting on hostname can be useful.
A better commit would sort on host+port but this one is likely good
enough.