-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial prototype of Slack integration #172
base: stable
Are you sure you want to change the base?
Conversation
Awesome idea! It'll add another motivation to join and use Slack! |
I was able to activate it on PyladiesCZ from my account and I'm not an admin if I'm not mistaken. The only permissions I need is to lookup an user by e-mail and send a message to an user, and you can already do that if you are a member of the Slack, so I don't think that we require admin to add it. However, in this case we would need to set the Slack URL per course. |
@frenzymadness I installed the app on the international PyLadies Slack, it seems to work fine. Should I add support for multiple Slack workspaces? (I'm a bit sad that the courses are fragmented in two Slacks though 😞) |
It would be nice to notify coaches that some participant has submitted a solution. However, to avoid spam, this should probably be opt-in. What about a subscribe button in a course/lesson? It could be used by coaches, and when active, these events would be then sent to their Slack account. |
Could we please finish this. Even without support for coaches, it is a good enhancement. We need it currently only for beginners course which uses PyLadies CZ slack. |
Sure. There are some pending questions, I think that @messa didn't have time to check this out yet. It should work as it is if you want to test it ASAP. I won't be able to code until the next weekend though, so if there are bugs I'll fix them next week. |
ping! |
@messa could you please look at this before the next PyLadies course? Thanks :) |
I'd very like this to be merged. @messa what is blocking us? |
Rebased on top of master. |
@messa I'd like to highlight this PR... PyLadies Olomouc would really love this enhancement! |
Changed the PR base to |
This PR adds Slack integration:
Notes:
Course
to find a session from a task id. It's not ideal, but as long as task IDs are unique across sessions in a single course, it should work.async
task so that it will not block the HTTP request.TODO: