Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#minor); hop-protocol; add Base config #2310

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

@dhruv-chauhan dhruv-chauhan linked an issue Aug 3, 2023 that may be closed by this pull request
@dhruv-chauhan
Copy link
Collaborator Author

Note: hop-protocol currently supports ETH and USDC bridging on Base. As and when more tokens are added, the subgraph will fail with a critical error and we will have to manually update config in sync with https://github.com/hop-protocol/hop/blob/develop/packages/core/src/addresses/mainnet.ts.

Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Generally try to avoid merging grafts into master as we want to be deliberate when grafting and not do it by accident.

@dhruv-chauhan dhruv-chauhan merged commit 0dabd7a into messari:master Aug 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#bug; Hop Protocol Error
2 participants