Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#patch) aave-v2 bug incorrect argument in handleReserveDataUpdated #2314

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

tnkrxyz
Copy link
Collaborator

@tnkrxyz tnkrxyz commented Aug 6, 2023

This PR fixes a bug for aave-v2 in handleReserveDataUpdated. When calling _handleReserveDataUpdated, the 4th argument should be variableBorrowIndex, but it was set to variableBorrowRate.

@tnkrxyz
Copy link
Collaborator Author

tnkrxyz commented Aug 6, 2023

@bye43 , @dmelotik , I suppose there is some change in the PR process - I can no longer requet a reviewer myself. can either of you help review this PR?

Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good catch @tnkrxyz !

@melotik
Copy link
Contributor

melotik commented Aug 8, 2023

@dhruv-chauhan for visibility, this may be important to know for rebase purposes

@melotik melotik merged commit 0d33b93 into messari:master Aug 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants