Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#patch); pricelib; fix UniswapForksRouter.getLpTokenLiquidityUsdc decimals; add DPR override #2348

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

dhruv-chauhan
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan commented Aug 28, 2023

Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming fix, but LGTM! Nice work @dhruv-chauhan

@melotik
Copy link
Contributor

melotik commented Aug 29, 2023

@dhruv-chauhan the deployment you linked (https://okgraph.xyz/?q=dhruv-chauhan%2Farbitrum-one-bridge-ethereum-2) looks like it has the same issue

@dhruv-chauhan
Copy link
Collaborator Author

dhruv-chauhan commented Aug 31, 2023

TVL is calculated as,
tvl = getInputTokenAmountPrice(inputTokenBalance)

  • Inside getInputTokenAmountPrice, we would fetch the price of one token and multiply it by the amountof tokens
  • Fetching the price of a single token would bypass our liquidity bounding check, since multiplication by amount is done outside the pricelib
  • Updated the function to separately set a single token's price and its amount multiple

@dmelotik

@melotik melotik merged commit a98e9e5 into messari:master Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arbitrum-One-Bridge Ethereum: DELPER token causing huge TVL spike
2 participants