Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuantizationArgs schema to incorporate spinquant, etc. #195

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Oct 25, 2024

As we produce more "official" quantized models, we need a proper representation in ModelArgs to be able to represent the weights precisely.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 25, 2024
Copy link

30 passed

Copy link

@sacmehta sacmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ashwinb ashwinb merged commit 9db4fba into main Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants