Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page for music owner to manage Music NFTS #67

Open
3 of 5 tasks
thisisommore opened this issue Aug 29, 2022 · 6 comments · May be fixed by #85
Open
3 of 5 tasks

Page for music owner to manage Music NFTS #67

thisisommore opened this issue Aug 29, 2022 · 6 comments · May be fixed by #85
Assignees

Comments

@thisisommore
Copy link
Member

thisisommore commented Aug 29, 2022

  • Should see owned Music NFTs
  • Should see Adv NFT associated with it with expiry
  • Should allow to mint new Adv NFT if existing one is expired
  • Should allow to place on market and remove from it when required
  • Should able to burn ADV NFT and Music NFT
@thisisommore thisisommore added this to the MVP [EVMOS] milestone Aug 29, 2022
@mbappai mbappai self-assigned this Sep 12, 2022
@mbappai
Copy link
Contributor

mbappai commented Sep 12, 2022

We really should rename the AdvNFT to AdSpaceNFT for clarity sake when we get the change, it can get quite confusing sometimes TBH @thisisommore

@thisisommore
Copy link
Member Author

thisisommore commented Sep 13, 2022

We really should rename the AdvNFT to AdSpaceNFT for clarity sake when we get the change, it can get quite confusing sometimes TBH @thisisommore

Created an issue https://github.com/meta-web3-music/smart-contracts/issues/3

@mbappai
Copy link
Contributor

mbappai commented Sep 13, 2022

Since we're renaming, I think it'd be best if we replace every instance of Adv with Ad or Ads . I appreciate you for getting on this issue!

@thisisommore
Copy link
Member Author

thisisommore commented Sep 13, 2022

Since we're renaming, I think it'd be best if we replace every instance of Adv with Ad or Ads . I appreciate you for getting on this issue!

I will sure do for smart contract and will also do for frontend if you are occupied with different things.
Issue for frontend #84

@mbappai
Copy link
Contributor

mbappai commented Sep 13, 2022

Let's agree on the convention first.

  • Ad(s) (The ad itself which is an image ATM)
  • AdSpace(s) (The space where ads are placed)

I'll do the refactoring for the frontend whenever I come across the instance

@mbappai mbappai linked a pull request Sep 13, 2022 that will close this issue
@thisisommore
Copy link
Member Author

Let's agree on the convention first.

  • Ad(s) (The ad itself which is an image ATM)
  • AdSpace(s) (The space where ads are placed)

I'll do the refactoring for the frontend whenever I come across the instance

@mbappai please post this in https://github.com/meta-web3-music/smart-contracts/issues/3 there we can continue this discussion

@thisisommore thisisommore removed this from the MVP [EVMOS] milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants