-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds SP-initiated LogoutRequests #75
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 75.30% 75.03% -0.27%
==========================================
Files 10 10
Lines 656 693 +37
Branches 90 101 +11
==========================================
+ Hits 494 520 +26
Misses 72 72
- Partials 90 101 +11 ☔ View full report in Codecov by Sentry. |
This is a SAML 2.0 Clojure library for SSO acting as a fairly thin wrapper around the Java libraries [OpenSAML | ||
This is a SAML 2.0 Clojure library for SSO acting as a thin wrapper around the Java libraries [OpenSAML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me
Might be worth adding some info about this in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving because Cam approved but a small change invalidated his approval
The basic flow of a SAML logout is:
This adds
logout-redirect-location
andidp-logout-redirect-response
, which are used to send a LogoutRequest to an Identity Provider. Some users of this library (like Metabase) prefer to send the redirect url in a POST body, and let the client initiate the redirect, and that's whatlogout-redirect-location
is for.