Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove captcha #3253

Merged
merged 1 commit into from
Dec 21, 2024
Merged

remove captcha #3253

merged 1 commit into from
Dec 21, 2024

Conversation

haarg
Copy link
Member

@haarg haarg commented Dec 21, 2024

The captcha is being removed from the API because our identity providers already do enough checking for our purposes.

The captcha is being removed from the API because our identity providers
already do enough checking for our purposes.
@haarg haarg force-pushed the haarg/remove-captcha branch from 1d67bca to 53b7030 Compare December 21, 2024 12:55
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.42%. Comparing base (dd53856) to head (53b7030).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/MetaCPAN/Web/Controller/Account/Favorite.pm 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
+ Coverage   73.10%   73.42%   +0.32%     
==========================================
  Files          69       68       -1     
  Lines        2398     2386      -12     
  Branches      338      335       -3     
==========================================
- Hits         1753     1752       -1     
+ Misses        517      507      -10     
+ Partials      128      127       -1     
Files with missing lines Coverage Δ
app.psgi 81.81% <ø> (ø)
lib/MetaCPAN/Web/Authentication/User.pm 55.00% <ø> (ø)
lib/MetaCPAN/Web/Model/API/User.pm 60.71% <ø> (+4.04%) ⬆️
lib/MetaCPAN/Web/Controller/Account/Favorite.pm 15.15% <0.00%> (ø)

... and 2 files with indirect coverage changes

@haarg haarg merged commit f4c296d into master Dec 21, 2024
9 of 10 checks passed
@haarg haarg deleted the haarg/remove-captcha branch December 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants