Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate isDisabled parameter through boxed elements #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juanluisrp
Copy link
Member

With this change a user can define a boxed element as disabled. This commit propagates that parameter through these templates to render the fields as readonly.
For example, you could use it to set the /mdb:MD_Metadata/mdb:identificationInfo/mri:MD_DataIdentification/mri:citation/cit:CI_Citation/cit:citedResponsibleParty children fields as not editable because you want the users to select the contact from a search contact widget.

image

Related to ga-gn/core-geonetwork#19.

… select

With this change a user can define a boxed element as disabled. This commit propagates
that parameter through these templates to render the fields as readonly.

For example, you could use it to set the /mdb:MD_Metadata/mdb:identificationInfo/mri:MD_DataIdentification/mri:citation/cit:CI_Citation/cit:citedResponsibleParty
children fields as not editable because you want the users to select the
contact from a search contact widget.
@juanluisrp juanluisrp changed the title Propagate isDisable boxed elements Propagate isDisabled parameter through boxed elements Jul 16, 2020
Copy link
Contributor

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Something to manage in other PR probably would be to do similar stuff for iso19139 and also define and delegate in all templates all possible parameters, defined with default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants