Update fw-set edit commands to add/remove firmware from fw-sets #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the flags for add/remove individual fw in a fw-set and update the call sites to use the appropriate flag
diogomatsubara
changed the title
joelrebel
requested changes
Jul 31, 2023
This way we use the CLI processor to parse the given comma separated list of fw UUIDs into a []string
|
@diogomatsubara seems like the linter isn't happy |
joelrebel
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although originally (d146f3d) only fixed a no-op while removing fw from fw-sets, I made some further changes:
Let me know if you prefer this as individual PRs or if it's fine as is.