Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for lvm, cryptsetup, tpm2_tools #856

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add support for lvm, cryptsetup, tpm2_tools #856

merged 1 commit into from
Oct 1, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Sep 11, 2024

This commit ads elements to support the installation of:

  • tpm2_tools
  • cryptsetup
  • lvm2

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2024
tuminoid
tuminoid reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

...amic_worker_workflow/ipa_builder_elements/ipa-luks-tpm-support/install.d/99-install-luks-tpm Outdated Show resolved Hide resolved
...ripts/dynamic_worker_workflow/ipa_builder_elements/ipa-lvm-support/install.d/99-install-lvm2 Outdated Show resolved Hide resolved
...amic_worker_workflow/ipa_builder_elements/ipa-luks-tpm-support/install.d/99-install-luks-tpm Show resolved Hide resolved
...ripts/dynamic_worker_workflow/ipa_builder_elements/ipa-lvm-support/install.d/99-install-lvm2 Show resolved Hide resolved
@Rozzii
add support for lvm, cryptsetup, tpm2_tools
ab5074a 
This commit ads elements to support the installation of:
- tpm2_tools
- cryptsetup
- lvm2

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024

Test is not relevant these are just optional elements to install packages during IPA building, by default these elements are not used.
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

Test is not relevant these are just optional elements to install packages during IPA building, by default these elements are not used.
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii Rozzii requested a review from tuminoid October 1, 2024 06:36
@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024

/cc @adilGhaffarDev @smoshiur1237

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
tuminoid
tuminoid reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@metal3-io-bot metal3-io-bot merged commit cf10f81 into metal3-io:main Oct 1, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the ipa_modules_crypt_lvm branch October 1, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rozzii @metal3-io-bot @adilGhaffarDev @tuminoid