Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiddenSettings with incomplete cache #488

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

MarkSackerberg
Copy link
Contributor

Users try to create CMs with hiddenSettings without reveal, to have everyone mint the same NFT.
This allows it but throws warnings when the cache is incomplete like
sugar deploy
grafik

sugar reveal
grafik

@MarkSackerberg
Copy link
Contributor Author

Added a test to show that warning.
grafik

@MarkSackerberg MarkSackerberg merged commit 4ab5404 into main Sep 17, 2024
4 checks passed
@MarkSackerberg MarkSackerberg deleted the mark/hiddensettings-warning branch September 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants