Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker should handle middleware errors #12

Open
sprohaska opened this issue Jun 21, 2015 · 1 comment
Open

Picker should handle middleware errors #12

sprohaska opened this issue Jun 21, 2015 · 1 comment

Comments

@sprohaska
Copy link

Picker currently ignores middleware errors. For example ,req.body will be empty if the body parser size limit is violated.

As a workaround, I've added a hack to pass errors via req.error to my fork: sprohaska@284f626

Ideally, Picker should support express-style error route handler that take an additional err.

@halvardos
Copy link

This is a serious problem as it stands, having req.body be empty and no end event fired because of a silent failure in the middleware is extremely hard to identify and debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants