Add ingestion of non-scalar parameters #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lun4m
force-pushed
the
nonscalar_params
branch
from
8656801
to
79385aa
Compare
intarga
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the obsinn header parsing and implements the ingestion of non-scalar parameters to a separate
nonscalar_datatable, where for now theobsvaluehas typeTEXT. Once we have a clearer idea of what types of non-scalars we are dealing with and how they are used downstream we can come up with better database design.Edit: the number of lines affected has mostly to do with the fact that I added a new column to
paramconversions.csv.