Pre release #105
Open
Pre release #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus histograms are very expensive. This change removes service_name label from histograms, because it can explode cardinality.
fix duration bug in case of golang profile.
…bel-from-hists pyroscope-receiver: remove service label from hists
tomershafir
reviewed
Oct 18, 2024
receiver/pyroscopereceiver/README.md
Outdated
| @@ -11,6 +11,18 @@ Implements the Pyroscope ingest protocol and conveys the accepted profiles as Op | |||
|
|
|||
| - `protocols`: sets the application layer protocols that the receiver will serve. See [Supported Protocols](#supported-protocols). Default is http/s on 0.0.0.0:8062 with max request body size of: 5e6 + 1e6. | |||
| - `timeout`: sets the server reponse timeout. Default is 10 seconds. | |||
| - `metrics`: configures the metrics collection for the Pyroscope receiver. | |||
| - `enable`: enables or disables metrics collection. Default is true. | |||
| - `exclude_labels`: a list of label names to exclude from the metrics. Available labels are: | |||
There was a problem hiding this comment.
@akvlad I would like to keep service on the counters, and remove it from histograms. Maybe we can add an option to exclude the labels from spefiic metrics? Like an optional metric list for each label under exclude_labels
There was a problem hiding this comment.
Ok. I'll think about that.
There was a problem hiding this comment.
Rename the batchV2 struct to traceWithTagsBatch to improve code readability. Update the names of struct fields to make them more descriptive. Rename the traces_v2.go file to trace_batch_processor.go. Use a custom contextKey type in the pushTraceData function to resolve the SA1029 warning. Optimize README.md to provide more detailed configuration instructions. These changes are aimed at improving code quality, maintainability, and documentation clarity.
refactor: improve the code structure and documentation of qrynexporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.