Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] erratic behaviour of the plugin #15

Open
MrGGGabriel opened this issue May 30, 2024 · 8 comments
Open

[BUG] erratic behaviour of the plugin #15

MrGGGabriel opened this issue May 30, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@MrGGGabriel
Copy link

OS:

  • OS: Mac Os Sonoma 14.5

Describe the bug
The plugin work strangely, and have random renders.

To Reproduce
Example 1 of a strange behavior:

  1. Drag & drop a logo
  2. Choose Digital and Fullcolor only, apply 40 px margin.
  3. Message appear "Artwork is not the same color scheme" > Choosing right color scheme (or leaving the same)
  4. Logo is generated without margin
  5. If I set margins on the generated artboard, logo is not exporting anymore

Example 2 of a strange behavior:

  1. Drag & drop a logo
  2. Choose Print and Fullcolor + Black and White
  3. When generat message appear "Object "Execute script" is not available at the time".
  4. By clicking ok, artboard are generated "broken".
  5. Restarting illustrator and executing same steps may result on a good export.

The thing is that the plugin is working randomly. Maybe it's my setup ? I have activated Rosetta and debug mode.

@MrGGGabriel MrGGGabriel added the bug Something isn't working label May 30, 2024
@schroef
Copy link
Collaborator

schroef commented May 30, 2024

Can you show screen grabs of how the logo document looks when you have manually added the margin. I wonder why it's not exporting. Or perhaps share that document so I can check my self.

For the first issue, I'll try a run using a logo and using your steps to reproduce it.

Ps in the context menu of the panel (flyout menu), can you check which version you are using

@MrGGGabriel
Copy link
Author

MrGGGabriel commented May 30, 2024 via email

@schroef
Copy link
Collaborator

schroef commented May 31, 2024

ps you don't have to drag and drop the logo. It also works when you have a logo selected, then press generate.
You need to set all settings before you drag and drop a logo ontp the panel.

Try both methods, it could be drag and drop causes the issue. Last time I checked it was working.

@schroef
Copy link
Collaborator

schroef commented May 31, 2024

Okay, i just tested your first issue. I see there is an issue when only FullColor is selected
I got that fixed on my side. Ill try to upload it tomorrow to GitHub when i have more time. So you test it.

Now your second issue also works fine on my side, i think that was also related to the drag and drop not working

Seems something with the code to copy the logo using evalScript doesnt working properly in newer versions. Im ow using an extra command inside that loop when its waiting for a result. This now works on my side

EDIT 2
I just realised something. Can you try to drag and drop a logo without selecting it first. I think perhaps this is causing the issue. In the code it uses select all on artboard. I just now noticed when i first select it manually, than drag and drop. It doesnt generate properly using drag and drop. When i dont select anything on the artboard, than use drag and drop, it does work

dragndrop-no-selection.mp4

After testing more and more, it seems the drag and drop is not that stable. Perhaps we should take it out.

@MrGGGabriel
Copy link
Author

MrGGGabriel commented May 31, 2024 via email

@schroef
Copy link
Collaborator

schroef commented May 31, 2024

Though I first need to make a pull request. Than the dev of this GitHub needs to upload a new version to adobe and than we need to wait for approval, that takes time. My own GitHub wil have a working version but you need to do manual install. Which is a bit more work.

I'll do some more test tomorrow if I find time. Right now I see drag and drop working randomly. It's kinda weird

@schroef
Copy link
Collaborator

schroef commented Jun 3, 2024

I have a branch where it now works. Took some time to pinpoint it, but i believe it got it now.
You do need to install this manually according to the readme.md file
https://github.com/schroef/logo-packer/blob/fix_dragndrop

I also found some other issues, im still working on those

@schroef
Copy link
Collaborator

schroef commented Jun 28, 2024

@MrGGGabriel

Have you tried my version yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants