style: run rector

mewebstudio · Dec 28, 2024 · 24f83e4 · 24f83e4
1 parent 7a7c588
commit 24f83e4
Show file tree

Hide file tree

Showing 67 changed files with 136 additions and 68 deletions.
diff --git a/src/DataMapper/RequestDataMapper/AbstractRequestDataMapper.php b/src/DataMapper/RequestDataMapper/AbstractRequestDataMapper.php
@@ -17,8 +17,11 @@
 abstract class AbstractRequestDataMapper implements RequestDataMapperInterface
 {
     protected EventDispatcherInterface $eventDispatcher;
+
     protected RequestValueMapperInterface $valueMapper;
+
     protected RequestValueFormatterInterface $valueFormatter;
+
     protected CryptInterface $crypt;
 
     protected bool $testMode = false;

diff --git a/src/DataMapper/RequestValueFormatter/GarantiPosRequestValueFormatter.php b/src/DataMapper/RequestValueFormatter/GarantiPosRequestValueFormatter.php
@@ -57,10 +57,6 @@ public function formatCardExpDate(\DateTimeInterface $expDate, string $fieldName
      */
     public function formatDateTime(\DateTimeInterface $dateTime, string $fieldName = null, string $txType = null): string
     {
-        if (PosInterface::TX_TYPE_HISTORY === $txType && ('StartDate' === $fieldName || 'EndDate' === $fieldName)) {
-            return $dateTime->format('d/m/Y H:i');
-        }
-
         return $dateTime->format('d/m/Y H:i');
     }
 }
diff --git a/src/DataMapper/RequestValueFormatter/ToslaPosRequestValueFormatter.php b/src/DataMapper/RequestValueFormatter/ToslaPosRequestValueFormatter.php
@@ -53,6 +53,7 @@ public function formatDateTime(\DateTimeInterface $dateTime, string $fieldName =
         if ('timeSpan' === $fieldName) {
             return $dateTime->format('YmdHis');
         }
+
         if ('transactionDate' === $fieldName) {
             return $dateTime->format('Ymd');
         }

diff --git a/src/DataMapper/RequestValueMapper/AbstractRequestValueMapper.php b/src/DataMapper/RequestValueMapper/AbstractRequestValueMapper.php
@@ -84,7 +84,7 @@ public function getSecureTypeMappings(): array
      */
     public function mapSecureType(string $paymentModel): string
     {
-        if (0 === count($this->secureTypeMappings)) {
+        if ([] === $this->secureTypeMappings) {
             throw new \LogicException('Security type mappings are not supported.');
         }
 
@@ -120,7 +120,7 @@ public function getRecurringOrderFrequencyMappings(): array
      */
     public function mapRecurringFrequency(string $period): string
     {
-        if (0 === count($this->recurringOrderFrequencyMappings)) {
+        if ([] === $this->recurringOrderFrequencyMappings) {
             throw new \LogicException('Recurring frequency mappings are not supported.');
         }
 
@@ -132,7 +132,7 @@ public function mapRecurringFrequency(string $period): string
      */
     public function mapLang(string $lang): string
     {
-        if (0 === count($this->langMappings)) {
+        if ([] === $this->langMappings) {
             throw new \LogicException('Language mappings are not supported.');
         }
 
@@ -160,7 +160,7 @@ public function getCardTypeMappings(): array
      */
     public function mapCardType(string $cardType): string
     {
-        if (0 === count($this->cardTypeMappings)) {
+        if ([] === $this->cardTypeMappings) {
             throw new \LogicException('Card type mappings are not supported.');
         }
 

diff --git a/src/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapper.php b/src/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapper.php
@@ -516,6 +516,7 @@ private function mapSingleOrderHistoryTransaction(array $rawTx): array
             if (null !== $transTime) {
                 $defaultResponse['transaction_time'] = $this->valueFormatter->formatDateTime($transTime, $txType);
             }
+
             $defaultResponse['capture_time']     = null !== $rawTx['AuthDate'] ? $this->valueFormatter->formatDateTime($rawTx['AuthDate'], $txType) : null;
             $amount                              = $rawTx['AuthAmount'];
             $defaultResponse['capture_amount']   = null !== $amount ? $this->valueFormatter->formatAmount($amount, $txType) : null;

diff --git a/src/DataMapper/ResponseValueFormatter/GarantiPosResponseValueFormatter.php b/src/DataMapper/ResponseValueFormatter/GarantiPosResponseValueFormatter.php
@@ -17,11 +17,9 @@ public function formatInstallment(?string $installment, string $txType): int
             return 0;
         }
 
-        if (PosInterface::TX_TYPE_HISTORY === $txType) {
-            // history response
-            if ('Pesin' === $installment || '1' === $installment) {
-                return 0;
-            }
+        // history response
+        if (PosInterface::TX_TYPE_HISTORY === $txType && ('Pesin' === $installment || '1' === $installment)) {
+            return 0;
         }
 
         return parent::formatInstallment($installment, $txType);

diff --git a/src/DataMapper/ResponseValueMapper/AbstractResponseValueMapper.php b/src/DataMapper/ResponseValueMapper/AbstractResponseValueMapper.php
@@ -38,6 +38,7 @@ public function __construct(
         if ([] !== $txTypeMappings) {
             $this->txTypeMappings = $txTypeMappings;
         }
+
         if ([] !== $secureTypeMappings) {
             $this->secureTypeMappings = \array_flip($secureTypeMappings);
         }

diff --git a/tests/Unit/DataMapper/RequestDataMapper/AkbankPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/AkbankPosRequestDataMapperTest.php
@@ -41,7 +41,9 @@ class AkbankPosRequestDataMapperTest extends TestCase
     private array $order;
 
     private EventDispatcherInterface $dispatcher;
+
     private AkbankPosRequestValueFormatter $valueFormatter;
+
     private AkbankPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/EstPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/EstPosRequestDataMapperTest.php
@@ -38,7 +38,9 @@ class EstPosRequestDataMapperTest extends TestCase
 
     /** @var EventDispatcherInterface & MockObject */
     private EventDispatcherInterface $dispatcher;
+
     private EstPosRequestValueFormatter $valueFormatter;
+
     private EstPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/EstV3PosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/EstV3PosRequestDataMapperTest.php
@@ -37,8 +37,11 @@ class EstV3PosRequestDataMapperTest extends TestCase
 
     /** @var EventDispatcherInterface & MockObject */
     private EventDispatcherInterface $dispatcher;
+
     private EstPosRequestValueFormatter $valueFormatter;
+
     private EstPosRequestValueMapper $valueMapper;
+
     protected function setUp(): void
     {
         parent::setUp();

diff --git a/tests/Unit/DataMapper/RequestDataMapper/GarantiPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/GarantiPosRequestDataMapperTest.php
@@ -39,6 +39,7 @@ class GarantiPosRequestDataMapperTest extends TestCase
     private CryptInterface $crypt;
 
     private GarantiPosRequestValueFormatter $valueFormatter;
+
     private GarantiPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/InterPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/InterPosRequestDataMapperTest.php
@@ -39,6 +39,7 @@ class InterPosRequestDataMapperTest extends TestCase
     private EventDispatcherInterface $dispatcher;
 
     private InterPosRequestValueFormatter $valueFormatter;
+
     private InterPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/KuveytPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/KuveytPosRequestDataMapperTest.php
@@ -38,6 +38,7 @@ class KuveytPosRequestDataMapperTest extends TestCase
     private EventDispatcherInterface $dispatcher;
 
     private KuveytPosRequestValueFormatter $valueFormatter;
+
     private KuveytPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/PayFlexCPV4PosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/PayFlexCPV4PosRequestDataMapperTest.php
@@ -37,6 +37,7 @@ class PayFlexCPV4PosRequestDataMapperTest extends TestCase
     private CryptInterface $crypt;
 
     private PayFlexCPV4PosRequestValueFormatter $valueFormatter;
+
     private PayFlexCPV4PosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapperTest.php
@@ -37,6 +37,7 @@ class PayFlexV4PosRequestDataMapperTest extends TestCase
     private EventDispatcherInterface $dispatcher;
 
     private PayFlexV4PosRequestValueFormatter $valueFormatter;
+
     private PayFlexV4PosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/PayForPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/PayForPosRequestDataMapperTest.php
@@ -36,7 +36,9 @@ class PayForPosRequestDataMapperTest extends TestCase
 
     /** @var EventDispatcherInterface & MockObject */
     private EventDispatcherInterface $dispatcher;
+
     private PayForPosRequestValueFormatter $valueFormatter;
+
     private PayForPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/PosNetRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/PosNetRequestDataMapperTest.php
@@ -40,6 +40,7 @@ class PosNetRequestDataMapperTest extends TestCase
     private CryptInterface $crypt;
 
     private PosNetRequestValueFormatter $valueFormatter;
+
     private PosNetRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/PosNetV1PosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/PosNetV1PosRequestDataMapperTest.php
@@ -39,6 +39,7 @@ class PosNetV1PosRequestDataMapperTest extends TestCase
     private CryptInterface $crypt;
 
     private PosNetV1PosRequestValueFormatter $valueFormatter;
+
     private PosNetV1PosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/ToslaPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/ToslaPosRequestDataMapperTest.php
@@ -37,6 +37,7 @@ class ToslaPosRequestDataMapperTest extends TestCase
     private ToslaPosRequestDataMapper $requestDataMapper;
 
     private ToslaPosRequestValueFormatter $valueFormatter;
+
     private ToslaPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestDataMapper/VakifKatilimPosRequestDataMapperTest.php b/tests/Unit/DataMapper/RequestDataMapper/VakifKatilimPosRequestDataMapperTest.php
@@ -38,6 +38,7 @@ class VakifKatilimPosRequestDataMapperTest extends TestCase
     private CryptInterface $crypt;
 
     private VakifKatilimPosRequestValueFormatter $valueFormatter;
+
     private VakifKatilimPosRequestValueMapper $valueMapper;
 
     protected function setUp(): void

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/AkbankPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/AkbankPosRequestValueFormatterTest.php
@@ -26,7 +26,7 @@ protected function setUp(): void
      *            [1, 1]
      *            [2, 2]
      */
-    public function testFormatInstallment($installment, int $expected): void
+    public function testFormatInstallment(int $installment, int $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/EstPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/EstPosRequestValueFormatterTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
      *            [1, ""]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/GarantiPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/GarantiPosRequestValueFormatterTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
      *            [1, ""]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/InterPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/InterPosRequestValueFormatterTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
      *            [1, ""]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/KuveytPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/KuveytPosRequestValueFormatterTest.php
@@ -26,7 +26,7 @@ protected function setUp(): void
      *            [1, "0"]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/PayFlexCPV4PosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/PayFlexCPV4PosRequestValueFormatterTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
      *            [1, "0"]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/PayFlexV4PosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/PayFlexV4PosRequestValueFormatterTest.php
@@ -26,7 +26,7 @@ protected function setUp(): void
      *            [1, "0"]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/PayForPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/PayForPosRequestValueFormatterTest.php
@@ -26,7 +26,7 @@ protected function setUp(): void
      *            [1, "0"]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/PosNetRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/PosNetRequestValueFormatterTest.php
@@ -29,7 +29,7 @@ protected function setUp(): void
      *            [2, "02"]
      *            [12, "12"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/PosNetV1PosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/PosNetV1PosRequestValueFormatterTest.php
@@ -28,7 +28,7 @@ protected function setUp(): void
      *            [1, "0"]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/ToslaPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/ToslaPosRequestValueFormatterTest.php
@@ -25,7 +25,7 @@ protected function setUp(): void
      *            [1, 0]
      *            [2, 2]
      */
-    public function testFormatInstallment($installment, int $expected): void
+    public function testFormatInstallment(int $installment, int $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);
@@ -78,7 +78,7 @@ public function testFormatDateTime(?string $fieldName, string $expected): void
      * [null]
      * [""]
      */
-    public function testFormatDateTimeUnsupportedField($fieldName): void
+    public function testFormatDateTimeUnsupportedField(?string $fieldName): void
     {
         $dateTime = new \DateTime('2024-04-14T16:45:30.000');
         $this->expectException(\InvalidArgumentException::class);

diff --git a/tests/Unit/DataMapper/RequestValueFormatter/VakifKatilimPosRequestValueFormatterTest.php b/tests/Unit/DataMapper/RequestValueFormatter/VakifKatilimPosRequestValueFormatterTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
      *            [1, "0"]
      *            [2, "2"]
      */
-    public function testFormatInstallment($installment, string $expected): void
+    public function testFormatInstallment(int $installment, string $expected): void
     {
         $actual = $this->formatter->formatInstallment($installment);
         $this->assertSame($expected, $actual);
@@ -79,7 +79,7 @@ public function testFormatDateTime(\DateTimeInterface $dateTime, ?string $fieldN
      * [null]
      * [""]
      */
-    public function testFormatDateTimeUnsupportedField($fieldName): void
+    public function testFormatDateTimeUnsupportedField(?string $fieldName): void
     {
         $dateTime = new \DateTime('2024-04-14T16:45:30.000');
         $this->expectException(\InvalidArgumentException::class);

diff --git a/tests/Unit/DataMapper/RequestValueMapper/AkbankPosRequestValueMapperTest.php b/tests/Unit/DataMapper/RequestValueMapper/AkbankPosRequestValueMapperTest.php
@@ -18,7 +18,7 @@ class AkbankPosRequestValueMapperTest extends TestCase
 
     private AkbankPosRequestValueMapper $valueMapper;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
         $this->valueMapper = new AkbankPosRequestValueMapper();
@@ -96,7 +96,7 @@ public function testGetTxTypeMappings(): void
         $this->assertCount(8, $this->valueMapper->getTxTypeMappings());
     }
 
-    public function testGetSecureTypeMappings()
+    public function testGetSecureTypeMappings(): void
     {
         $this->assertCount(4, $this->valueMapper->getSecureTypeMappings());
     }

diff --git a/tests/Unit/DataMapper/RequestValueMapper/EstPosRequestValueMapperTest.php b/tests/Unit/DataMapper/RequestValueMapper/EstPosRequestValueMapperTest.php
@@ -17,7 +17,7 @@ class EstPosRequestValueMapperTest extends TestCase
 {
     private EstPosRequestValueMapper $valueMapper;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
         $this->valueMapper = new EstPosRequestValueMapper();
@@ -95,7 +95,7 @@ public function testGetTxTypeMappings(): void
         $this->assertCount(8, $this->valueMapper->getTxTypeMappings());
     }
 
-    public function testGetSecureTypeMappings()
+    public function testGetSecureTypeMappings(): void
     {
         $this->assertCount(5, $this->valueMapper->getSecureTypeMappings());
     }

diff --git a/tests/Unit/DataMapper/RequestValueMapper/GarantiPosRequestValueMapperTest.php b/tests/Unit/DataMapper/RequestValueMapper/GarantiPosRequestValueMapperTest.php
@@ -17,7 +17,7 @@ class GarantiPosRequestValueMapperTest extends TestCase
 {
     private GarantiPosRequestValueMapper $valueMapper;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
         $this->valueMapper = new GarantiPosRequestValueMapper();
@@ -95,7 +95,7 @@ public function testGetTxTypeMappings(): void
         $this->assertCount(9, $this->valueMapper->getTxTypeMappings());
     }
 
-    public function testGetSecureTypeMappings()
+    public function testGetSecureTypeMappings(): void
     {
         $this->assertCount(2, $this->valueMapper->getSecureTypeMappings());
     }