fix(cache): made caching keys Command/Query name and metadata argumen…

…ts dependant
mezdelex · Jul 31, 2024 · 339762c · 339762c
1 parent a0e13cc
commit 339762c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/Application/Categories/GetAllAsync/GetAllCategoriesQueryHandler.cs b/src/Application/Categories/GetAllAsync/GetAllCategoriesQueryHandler.cs
@@ -24,8 +24,9 @@ public async Task<PagedList<CategoryDTO>> Handle(
         CancellationToken cancellationToken
     )
     {
+        var redisKey = $"{nameof(GetAllCategoriesQuery)}#{request.Page}#{request.PageSize}";
         var cachedGetAllCategoriesQuery = await _redisCache.GetCachedData<PagedList<CategoryDTO>>(
-            nameof(GetAllCategoriesQuery)
+            redisKey
         );
         if (cachedGetAllCategoriesQuery != null)
             return cachedGetAllCategoriesQuery;
@@ -37,7 +38,7 @@ CancellationToken cancellationToken
             .ToPagedListAsync(request.Page, request.PageSize, cancellationToken);
 
         await _redisCache.SetCachedData<PagedList<CategoryDTO>>(
-            nameof(GetAllCategoriesQuery),
+            redisKey,
             pagedCategories,
             DateTimeOffset.Now.AddMinutes(5)
         );

diff --git a/tests/Application/UnitTests/Categories/GetAllAsync/GetAllCategoriesQueryHandlerTests.cs b/tests/Application/UnitTests/Categories/GetAllAsync/GetAllCategoriesQueryHandlerTests.cs
@@ -35,6 +35,7 @@ public async Task GetAllCategoriesQueryHandler_ShouldReturnPagedListOfRequestedC
         var page = 1;
         var pageSize = 2;
         var getAllCategoriesQuery = new GetAllCategoriesQuery(page, pageSize);
+        var redisKey = $"{nameof(GetAllCategoriesQuery)}#{page}#{pageSize}";
         var categories = new List<Category>
         {
             new(Guid.NewGuid(), "Name 1", "Description 1"),
@@ -62,14 +63,12 @@ public async Task GetAllCategoriesQueryHandler_ShouldReturnPagedListOfRequestedC
             .Returns(categories.AsQueryable().GetEnumerator());
         _context.Setup(mock => mock.Categories).Returns(_dbSet.Object).Verifiable();
         _redisCache
-            .Setup(mock =>
-                mock.GetCachedData<PagedList<CategoryDTO>>(nameof(GetAllCategoriesQuery))
-            )
+            .Setup(mock => mock.GetCachedData<PagedList<CategoryDTO>>(redisKey))
             .ReturnsAsync((PagedList<CategoryDTO>)null!);
         _redisCache
             .Setup(mock =>
                 mock.SetCachedData(
-                    nameof(GetAllCategoriesQuery),
+                    redisKey,
                     It.IsAny<PagedList<CategoryDTO>>(),
                     It.IsAny<DateTimeOffset>()
                 )
@@ -93,13 +92,13 @@ public async Task GetAllCategoriesQueryHandler_ShouldReturnPagedListOfRequestedC
         result.HasNextPage.Should().Be(false);
         _context.Verify();
         _redisCache.Verify(
-            mock => mock.GetCachedData<PagedList<CategoryDTO>>(nameof(GetAllCategoriesQuery)),
+            mock => mock.GetCachedData<PagedList<CategoryDTO>>(redisKey),
             Times.Once
         );
         _redisCache.Verify(
             mock =>
                 mock.SetCachedData(
-                    nameof(GetAllCategoriesQuery),
+                    redisKey,
                     It.IsAny<PagedList<CategoryDTO>>(),
                     It.IsAny<DateTimeOffset>()
                 ),