Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MA0051 supports skip_local_functions when counting lines #562

Merged
merged 1 commit into from
Jul 19, 2023
Merged

MA0051 supports skip_local_functions when counting lines #562

merged 1 commit into from
Jul 19, 2023

Conversation

meziantou
Copy link
Owner

@meziantou meziantou commented Jul 19, 2023 •
edited
Loading

Fix #561

@meziantou meziantou mentioned this pull request Jul 19, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #562 (bb9d80b) into main (2251423) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   90.14%   90.18%   +0.03%     
==========================================
  Files         177      177              
  Lines       12986    12995       +9     
==========================================
+ Hits        11706    11719      +13     
+ Misses       1280     1276       -4
Impacted Files Coverage Δ
...Analyzer/Rules/MethodShouldNotBeTooLongAnalyzer.cs 85.84% <100.00%> (+5.43%) ⬆️

@meziantou meziantou marked this pull request as ready for review July 19, 2023 23:46
@meziantou meziantou enabled auto-merge (squash) July 19, 2023 23:46
@meziantou meziantou merged commit 2de2b53 into main Jul 19, 2023
20 checks passed
@meziantou meziantou deleted the issues/561 branch July 19, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip_local_functions is not respected when counting method lines
1 participant
@meziantou