From 9d0baac237ee390a70b29a91898b3ba5c10bd947 Mon Sep 17 00:00:00 2001 From: Martin Gencur Date: Mon, 29 Jul 2024 14:16:09 +0200 Subject: [PATCH] Do not run TestTLSCertificateRotation in parallel with other tests (#776) This test deletes the serving-tests/serving-certs during the test run. This might break the other test TestSystemInternalTLS because it waits for certain log lines to appear in the service pods. Deleting the serving-certs secret causes the application pods to be deleted so that the new cert can be mounted. And waiting for given log lines then fails because the pod no longer exists: system_internal_tls_test.go:110: TLS not used on requests to queue-proxy: pods "system-internal-tls-wgvxqtyx-00001-deployment-6fdc4c8c7d-4ll8q" not found --- test/e2e/systeminternaltls/system_internal_tls_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/e2e/systeminternaltls/system_internal_tls_test.go b/test/e2e/systeminternaltls/system_internal_tls_test.go index fbf16b7ff73e..30bfbec1f167 100644 --- a/test/e2e/systeminternaltls/system_internal_tls_test.go +++ b/test/e2e/systeminternaltls/system_internal_tls_test.go @@ -122,8 +122,6 @@ func TestTLSCertificateRotation(t *testing.T) { t.Skip("Skip this test for non-kourier or non-istio ingress.") } - t.Parallel() - clients := test.Setup(t) names := test.ResourceNames{