Skip to content

Commit

Permalink
pass check-report errors to next job using artifact
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] committed Sep 23, 2024
1 parent 28eccde commit 949db7a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
17 changes: 17 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,14 @@ jobs:
--api-url=${{ github.event.pull_request._links.self.href }}
cd ..
- name: Upload chart_report errors
uses: actions/upload-artifact@v4
if: ${{ always() && steps.check_report.outcome == 'failure' }}
with:
name: chart_report_errors
path: pr/errors
if-no-files-found: ignore

- name: Delete Namespace
if: ${{ always() && steps.oc_login.conclusion == 'success' }}
env:
Expand Down Expand Up @@ -428,11 +436,20 @@ jobs:
../ve1/bin/pip3 install .
cd ..
# Submission information should always be present
- name: Download submission information
uses: actions/download-artifact@v4
with:
name: submission

# Chart report errors are only present if any error has occured during the chart_report
- name: Download chart_report errors
uses: actions/download-artifact@v4
if: ${{ needs.chart-verifier.outputs.check_report-outcome || 'skipped' == 'failure' }}
with:
name: chart_report_errors
path: pr/

- name: Prepare PR comment
id: pr_comment
if: ${{ needs.setup.outputs.run_build == 'true' }}
Expand Down
2 changes: 1 addition & 1 deletion scripts/src/pullrequest/prepare_pr_comment.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def prepare_failure_comment():
msg = append_to(msg, get_verifier_errors_comment())
msg = append_to(msg, errors)
msg = append_to(msg, get_verifier_errors_trailer())
gitutils.add_output("error-message", errors)
# gitutils.add_output("error-message", errors)
else:
gitutils.add_output("error-message", get_failure_comment())
return msg
Expand Down

0 comments on commit 949db7a

Please sign in to comment.