forked from openshift-helm-charts/development
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Better handle oc-install outcome (openshift-helm-charts#288)
The oc-install step doesn't continue-on-error, hence we should use .outcome instead of .conclusion to check if it runned successfully, was skipped or failed. This information is never empty, hence there is no need to default the value of this argument to False in prepare_pr_comment.py. Closes openshift-helm-charts#287 Signed-off-by: Matthias Goerens <mgoerens@redhat.com>
- Loading branch information
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters