Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST3 support #9

Open
ArmorDarks opened this issue Oct 2, 2013 · 14 comments
Open

ST3 support #9

ArmorDarks opened this issue Oct 2, 2013 · 14 comments

Comments

@ArmorDarks
Copy link

Is there any chances we'll see ST3 support?

Thanks

@mgussekloo
Copy link
Owner

I'll be looking into that soon, I haven't switched to ST3 myself. I was hoping ST3 would support this tab-behaviour natively but that may not be the case.

@ArmorDarks
Copy link
Author

Yeap, unfortunately ST3 doesn't :(

@mgussekloo
Copy link
Owner

I've updated the plugin, now compatible with ST3. Let me know if it works for you, any feedback welcome!

@kamisaibou
Copy link

As of a few days ago Tabright has stopped working with ST2 for me. If I open more than one tab in any group (I work with a 2 column layout) ST2 crashes - and from there continues to crash every time I try to open it. In order to get ST2 to work again I deleted Tabright from the packages directory and removed the entry for it in Packages/User/Package Control.sublime-settings.

@mgussekloo
Copy link
Owner

Thanks for your reply! I've updated the plugin, could you help me testing please?

@mgussekloo mgussekloo reopened this Oct 22, 2013
@kamisaibou
Copy link

Deleted my previous comment as I've just found an issue... When I have at least one tab open in each group and do any of the following, the tabs all start flickering and I can't consistently click on one to either close it or make it the active tab:

  • close and reopen ST2
  • switch the project in the current window
  • open a project in a new window

If I go Preferences > Package Control and then esc, it stops; similarly ctrl+p and then esc stops it. As soon as I've closed all of the tabs in one group it stops. Occasionally when using the Package Control menu to stop the flickering, I end up with nothing where the tabs should be instead of tabs (I think it depends on whether the tabs are visible or not at the exact instance I get into the menu, and they're visible more than they aren't).

Dragging tabs (not necessarily between groups):

  • When I try to drag a tab in the left group before I've dragged a tab in the right group, ST2 crashes most of the time. When it doesn't crash, it's always if I've clicked and held for a second before trying to drag the tab (but it still crashes some of the time when I do this). If I am able to drag a tab in the left group, trying to drag a tab in the right group always causes ST2 to crash.
  • After I've moved a tab in the right group to the left group, if I try to drag another tab in the right group, ST2 crashes most of the time (and occasionally the tabs will start flickering for a second or so before it crashes).
  • When I drag tabs between groups and it does work, the moved tab appears leftmost rather than rightmost. I haven't changed any of the default settings, so I have "open_new_tabs_at": "far_right" in the config.

Let me know if there's anything specific I should try - those were the cases I thought of but it's a little difficult to reproduce as the parts relating to dragging tabs aren't behaving consistently every time.

@mgussekloo
Copy link
Owner

Thanks for the excellent bug report! I'll try to resolve all these bugs but it might take a while... This is my first and only Python / SublimeText project :) I've updated the plugin yesterday to work better with groups / dragging / resorting. I'm not sure if that also fixes the "projects" bugs though. Let me know what I should look in to...

@kamisaibou
Copy link

Thank you for the quick update! :) I'm very glad to be able to use Tabright again... So far everything seems to be working.

@kamisaibou
Copy link

One more thing: if I create a new view into a file, trying to close the tab with the new view before closing the original tab causes Sublime to crash. This happens regardless of which group the new tab is in, regardless of if I've moved it between groups, and regardless of how I'm trying to close the file (ctrl + w, clicking the close button, middle clicking the tab). It also seems to carry between sessions - I can close Sublime and reopen it, and closing the newer tab will still cause it to crash.

@mgussekloo
Copy link
Owner

Thanks for the feedback! Hm, I can not reproduce the problem correctly here in St2... If you have any more info please let me know and I'll try to fix it.

@kamisaibou
Copy link

The simplest way to reproduce it for me is...

  1. Create a new file
  2. Create a new view into the file
  3. Close the new view into the file; it crashes here.

This happens even if I have no other files open and I have the "single" layout instead of my two-column one.

@mgussekloo
Copy link
Owner

Was this ever resolved? I'll close this issue because I couldn't reproduce it, but if it persists... Let me know and I'll look into it again.

@kamisaibou
Copy link

Not resolved - as described in my last comment it does still happen: creating a new view into a file and then closing the new view or the original view (had not tested this previously) crashes Sublime. This is the only consistent way I can cause the issue.

Additionally, it seems like if I move one of the view tabs to another group before trying to close either of them, then Sublime does not crash - even if I move the tab to another group, and then back to the group it came from.

It also is causing Sublime to crash once in a while when moving/closing tabs but not often and not consistently - maybe a few times a week, when doing the same action I've done dozens of times without it crashing... But I'm not sure what to say as far as reproducing this! Hopefully it's tied to the same problem as the first part.

@mgussekloo mgussekloo reopened this Feb 17, 2014
@ctf0
Copy link

ctf0 commented Nov 7, 2014

not working on ST3 b3066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants